[patch] midori fails to build with libnotify-0.7 API

Bug #710352 reported by Samuli Suominen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
High
Cris Dywan

Bug Description

[ .. ]

[28/75] cc: midori/midori-searchaction.c -> _build_/default/midori/midori-searchaction_1.o
[29/75] cc: midori/midori-view.c -> _build_/default/midori/midori-view_1.o
../midori/midori-app.c: In function ‘midori_app_send_notification’:
../midori/midori-app.c:1207:9: error: too many arguments to function ‘notify_notification_new’
/usr/include/libnotify/notification.h:114:21: note: declared here
[30/75] cc: midori/midori-viewable.c -> _build_/default/midori/midori-viewable_1.o

[ .. ]

Patch attached. It's compatible with old libnotify too. The NOTIFY_CHECK_VERSION was introduced in 0.5.x series, so we define the dummy for 0.4.x series. This is pretty much how it's fixed in eg. Orage or Thunar at Xfce git.

Revision history for this message
Samuli Suominen (ssuominen) wrote :
Michael Moroni (airon90)
tags: added: libnotify patch
Cris Dywan (kalikiana)
Changed in midori:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Christian Dywan (kalikiana)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks a lot, right in time for release.

Changed in midori:
status: Confirmed → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.