Review Saudi Arabia calendar as it has suspicious code
Bug #1209603 reported by
Richard Gomes
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| JQuantLib |
Fix Released
|
Medium
|
Richard Gomes | ||
Bug Description
In spite islamic calendar can be considered uncertain, according to links reported here, the current code in SaudiArabia.java has suspicious code which tests only 2004 and 2005.
The code must be changed according to reliable official sources of information.
http://
http://
http://
=============
Relationships
=============
child of http://
Revision history for this message
| Richard Gomes (frgomes) wrote | #1 |
Revision history for this message
| Richard Gomes (frgomes) wrote | #2 |
Revision history for this message
| Richard Gomes (frgomes) wrote | #3 |
Revision history for this message
| Richard Gomes (frgomes) wrote | #4 |
To post a comment you must log in.
I've done some cosmetic changes in order to make it look like other calendars.
This class needs a complete code review, specially because Islamic calendar is absolutely uncertain. Holidays are determined by visual observation of natural events, like the full moon after another uncertain holiday. The visual observation can be affected by a cloudy weather and it changes the outcome of it.
For this reason, past years must be verified against some reliable source.
Current and future years need to be reviewed.