smart server gives traceback on connection errors

[Robert Collins]

 affects /products/bzr
$ bzr merge bzr+ssh://HOST/branch
ssh: connect to host HOST port 22: Connection timed out
ssh_exchange_identification: Connection closed by remote host
bzr: ERROR: exceptions.AssertionError: end of file reading from server.

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 650, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 612, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 304, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.4/site-packages/bzrlib/builtins.py", line 2275, in run
    reader = bundle.read_bundle_from_url(branch)
  File "/usr/lib/python2.4/site-packages/bzrlib/bundle/__init__.py", line 46, in read_bundle_from_url
    f = t.get(filename)
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/smart.py", line 1046, in get
    return StringIO(self.get_bytes(relpath))
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/smart.py", line 1052, in get_bytes
    resp = protocol.read_response_tuple(True)
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/smart.py", line 1490, in read_response_tuple
    result = self._recv_tuple()
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/smart.py", line 1521, in _recv_tuple
    assert new_char != '', "end of file reading from server."
AssertionError: end of file reading from server.

bzr 0.14.0 on python 2.4.4.candidate.1 (linux2)
arguments: ['/usr/bin/bzr', 'merge', 'bzr+ssh://HOST/branch']
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Alexander Belchenko (bialix)]

Robert Collins пишет:
> Public bug reported:
>
> affects /products/bzr
> $ bzr merge bzr+ssh://HOST/branch
> ssh: connect to host HOST port 22: Connection timed out
> ssh_exchange_identification: Connection closed by remote host
> bzr: ERROR: exceptions.AssertionError: end of file reading from server.

BTW, too many smart server tests fails on windows with the same error.
I post the report after 0.14 release.

[Bubba Siggler (bud3)]

I agree even I am running feisty. There is a lot of mail that has this trace back it starts out lines 650. 612 etc):

[Martin Pool (mbp)]

On 3/30/07, Bubba Siggler <email address hidden> wrote:
> I agree even I am running feisty. There is a lot of mail that has this
> trace back it starts out lines 650. 612 etc):

What mail is that?

--
Martin

[Bubba Siggler (bud3)]

I was Thinking of asking you Guys if setting up a win 2k sp4 : By the way I would like to apologize for any thing that it out of line. I am new but what you Guys & Gals are doing is leading the next generation move.

[Bubba Siggler (bud3)]

I have no idea what mail. I subscribed to bzr its mail collaboration learning for me What get sent to me it say me. I focus on that mail. I treat it as your mail archive to its self. Just like the mailman except he is way better that I.

[Martin Pool (mbp)]

This particular code is now gone, as we no longer have assertions.

If the connection is refused you now get a reasonable error with no traceback. I'm not sure about timeouts.

mbp@grace% bzr log bzr+ssh://launchpad.net/
ssh: connect to host launchpad.net port 22: Connection refused
bzr: ERROR: Connection closed: please check connectivity and permissions

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/82634