MIR for ctdb

[Chuck Short]

Binary package hint: ctdb

Hi,

I would like to include ctdb in main. It is apart of the server-lucid-seeds specification. The MIR can be found at:

https://wiki.ubuntu.com/MIRctdb

If you have any questions let me know.

Regards
chuck

[Loïc Minier (lool)]

Took a quick first look; maintenance was indeed solid in Debian; will the server team subscribe to the bugs in Ubuntu?

I was a bit surprized to find:
configure: WARNING: the provided readdir() is broken
in the build log and *many*:
server/ctdb_lockwait.c:140: warning: ignoring return value of 'write', declared with attribute warn_unused_result
server/eventscript.c:53: warning: ignoring return value of 'system', declared with attribute warn_unused_result
etc.
(surprizing because I imagine this software is meant to improve reliability, yet it would not have solid error handling?)

Didn't actually look at the source code to check whether these are actual issues; could you check and/or bring this up with upstrean?

You will need to MIR tdb first or drop the ctdb depends on tdb-tools.

[Chuck Short (zulcss)]

The gcc warnings should be addressed as well.

chuck

[Loïc Minier (lool)]

NB: tdb is already in main, just tdb-tools isn't, but that's just a binary package from tdb.

[Loïc Minier (lool)]

Will you move to upstart? In any case, please change the init script to call bash explicitly instead of using /bin/sh:
% checkbashisms debian/ctdb.init
possible bashism in debian/ctdb.init line 215 (should be 'b = a'):
    if [ yes == "$CTDB_SUPPRESS_COREFILE" ]; then
possible bashism in debian/ctdb.init line 216 (ulimit):
        ulimit -c 0
possible bashism in debian/ctdb.init line 218 (ulimit):
        ulimit -c unlimited

[Loïc Minier (lool)]

Suggestion: /var/log/log.ctdb sounds kind of a stupid logname, how about ctdb.log instead?

[Loïc Minier (lool)]

FYI, the rules aren't -j safe:
clean: clean-patched unpatch

The testsuite isn't run during build; that would definitely be welcome; I could run it with ./configure && make && cd tests && scripts/run_tests simple/*.sh here.

There's a new upstream available.

So overall, I don't mind too much if there's a commitment from the Ubuntu Server team to take care of it, but the fact that this is a custom C daemon running *as root* and processing its own packet types from the network do ring the alarm bells.

Is there any plan to limit traffic to the local network at least?

In any case, I think I'll have to ask Ubuntu Security to take a look here.

[Loïc Minier (lool)]

There are 3 failing tests for me:
TEST FAILED: simple/11_ctdb_ip.sh (status 1) (duration: 2s)
TEST FAILED: simple/16_ctdb_config_add_ip.sh (status 1) (duration: 42s)
TEST FAILED: simple/52_ctdb_fetch.sh (status 1) (duration: 31s)

[Chuck Short (zulcss)]

After some discussion we arent going to include this in main.

[urusha (urusha)]

Hi. My suggestion is to discuss moving ctdb to main again. Clustered samba with ctdb is really nice and easy HA solution that should be available for installation. Just want to know what is the reason for not including it at the moment? Thanks.

[Nec (nicolas-ecarnot)]

Hi.
Let's suppose ctdb move to main again.
Would that be a way to lead Samba maintainers to re-activate clustering and ctdb configure options at build time?