Hotplug remove and re-add adds PCI adapter to next PCI domain (PCI)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Tim Gardner | ||
Yakkety |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
== Comment: #26 - Guilherme Guaglianoni Piccoli <email address hidden> - 2016-07-15 16:26:38 ==
When performing hotplug operations in PowerPC currently, if we remove a PHB and re-add it later, its domain address is incremented. An example below (drmgr is the tool we use in PowerPC to perform this operation):
(i) $> lspci
0000:60:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM57810 10 Gigabit Ethernet
0000:60:00.1 Ethernet controller: Broadcom Corporation NetXtreme II BCM57810 10 Gigabit Ethernet
(ii) $> drmgr -c phb -s "PHB 20" -r # removing a PHB
(iii) $> lspci #empty
(iv) $> drmgr -c phb -s "PHB 20" -a # re-adding the PHB
(v) $> lspci
0001:60:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM57810 10 Gigabit Ethernet
0001:60:00.1 Ethernet controller: Broadcom Corporation NetXtreme II BCM57810 10 Gigabit Ethernet
This behavior is harmful when kernel is using network predictable naming for interfaces, for example, since after the PHB re-add, the PCI address of NIC functions changes, and so the interfaces' naming also change. Recently, a patch was merged to powerpc-next to avoid this situation, by relating the PCI domain number with device-tree properties. With the patch, the above steps (i) and (v) present the same output for lspci.
We want to ask Canonical to merge the patch in Ubuntu Xenial's kernel, since it will solve multiple bugs we've experienced by performing NIC hotplug - the commit is present on powerpc-next under the commit-id 63a72284b15.
A link to the patch: https:/
Thanks in advance,
Guilherme
tags: | added: architecture-ppc64le bugnameltc-136437 severity-high targetmilestone-inin16041 |
Changed in ubuntu: | |
assignee: | nobody → Taco Screen team (taco-screen-team) |
affects: | ubuntu → linux (Ubuntu) |
Changed in linux (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu): | |
assignee: | Taco Screen team (taco-screen-team) → nobody |
Changed in linux (Ubuntu Yakkety): | |
assignee: | Taco Screen team (taco-screen-team) → nobody |
Changed in linux (Ubuntu): | |
status: | Fix Committed → Fix Released |
------- Comment From <email address hidden> 2016-07-15 18:14 EDT-------
FYI Canonical: This is an updated and upstream patch to address the issue originally documented in LP Bug 1560514.