SM: CI sanity fails because service_providers set twice in neutron config

[Nitish Krishna Kaveri]

In master branch, CI sanity SM lite jobs have failed after below check-in got merged:
https://review.opencontrail.org/#/c/15523/

This has unearthed an existing bug in SM provisioning which caused service_provider to be set twice in neutron.conf

The reason for this is described below

Neutron DEFAULT config brings in two values for that key as seen below:
# --- Reference implementations ---
service_provider=LOADBALANCER:Haproxy:neutron.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default
service_provider=VPN:openswan:neutron.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default

SM/Puppet uses Augeas which sets BOTH of those keys to configured value.

When above check-in got merged it returned ALL values of the key from neutron.conf instead of previously returning a hard-coded value. Since it expects only one value, this causes neutron plugin to fail.

This was handled in fab by first deleting both keys and they setting once.
We are now doing same in SM.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19421
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/19422
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19421
Committed: http://github.org/Juniper/contrail-puppet/commit/4579bca2fd1c881a0a10bafb6483c74dbe3f76c8
Submitter: Zuul
Branch: master

commit 4579bca2fd1c881a0a10bafb6483c74dbe3f76c8
Author: nitishkrishna <email address hidden>
Date: Mon Apr 18 20:50:20 2016 -0700

Closes-Bug: #1571935 - Service_provider in neutron.conf was wrongly being set twice

This change ensures that service_provider key in neutron.conf will be set only once
Previously it was being set twice causing neutron plugin to crash

Change-Id: If095a2db66b4de11383b810da0a24cb922535df4

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/19422
Committed: http://github.org/Juniper/contrail-puppet/commit/1de9999bebfa05dcab3e4e1dba402b793518c96e
Submitter: Zuul
Branch: R3.0

commit 1de9999bebfa05dcab3e4e1dba402b793518c96e
Author: nitishkrishna <email address hidden>
Date: Mon Apr 18 20:50:20 2016 -0700

Closes-Bug: #1571935 - Service_provider in neutron.conf was wrongly being set twice

This change ensures that service_provider key in neutron.conf will be set only once
Previously it was being set twice causing neutron plugin to crash

Change-Id: If095a2db66b4de11383b810da0a24cb922535df4