Old IP address remained even instance-ip was updated

[Daisuke Nakajima]

Old IP address remained even instance-ip was updated,so there were two IP address in a tap interface. Then Virtual-machine did not get New IP address by DHCP.

How to reproduce:
1) Create Virtual-machine.
2) Delete instance-IP attached to Virtual-machine
3) Create instance-IP of New IP address

please see Snh_Inet4UcRoute.xml. Old IP address is 10.1.1.5 and New one is 10.1.1.15. The tap interface is tap3482dada-de.

[Daisuke Nakajima (dnakajima)]

Analytics UVE shows the old IP address (10.1.1.5).

./Contrail_json.py -P 8081 -d "analytics/uves/virtual-machine-interface/default-domain:vyatta:3482dada-de83-44c0-8132-37348051dc35?flat"
{
    "UveVMInterfaceAgent": {
        "active": true,
        "gateway": "10.1.1.1",
        "if_stats": {
            "in_bw_usage": 0,
            "in_bytes": 0,
            "in_pkts": 0,
            "out_bw_usage": 0,
            "out_bytes": 0,
            "out_pkts": 0
        },
        "ip4_active": true,
        "ip6_active": false,
        "ip6_address": "::",
        "ip_address": "10.1.1.5",
        "l2_active": true,
        "label": 25,
        "mac_address": "02:34:82:da:da:de",
        "port_bucket_bmap": {
            "tcp_dport_bitmap": [
                "0",
                "0",
                "0",
                "0",
                "0",
                "0",
                "0",
                "0"
            ],
            "tcp_sport_bitmap": [
                "0",
                "0",
                "0",
                "0",
                "0",
                "0",
                "0",
                "0"
            ],
            "udp_dport_bitmap": [
                "1",
                "0",
                "0",
                "0",
                "0",
                "0",
                "0",
                "0"
            ],
            "udp_sport_bitmap": [
                "1",
                "0",
                "0",
                "0",
                "277119744",
                "931463168",
                "2186384641",
                "128"
            ]
        },
        "uuid": "3482dada-de83-44c0-8132-37348051dc35",
        "virtual_network": "default-domain:vyatta:vyatta-vn1",
        "vm_name": "ipchang1",
        "vm_uuid": "be8bbbe0-c242-4d78-9263-0f6b1932d32b"
    }
}

root@contrail-01:~/Document# nova list
+--------------------------------------+----------+--------+------------+-------------+----------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+----------+--------+------------+-------------+----------------------+
| be8bbbe0-c242-4d78-9263-0f6b1932d32b | ipchang1 | ACTIVE | - | Running | vyatta-vn1=10.1.1.15 |
| 9de2eb77-7dd6-491c-a90d-0a6e3f6d3868 | vyos1 | ACTIVE | - | Running | vyatta-vn1=10.1.1.3 |
| 004e874c-9dda-453b-b298-350e7050045b | vyos2 | ACTIVE | - | Running | vyatta-vn1=10.1.1.4 |
+--------------------------------------+----------+--------+------------+-------------+----------------------+

10.1.1.3/32 32 PT - 21 2:cc:e9:56:63:7f(231784)
10.1.1.4/32 32 LP 23 28 2:e4:f3:3:e2:d0(88180)
10.1.1.5/32 32 P - 32 2:34:82:da:da:de(64596) <<<<<
10.1.1.6/32 24 TF - 1 -
10.1.1.7/32 24 TF - 1 -
10.1.1.8/32 24 TF - ...

[Daisuke Nakajima (dnakajima)]

When we execute neutron port-update, new instance-ip is created and attached to existing VMI.
root@contrail-01:~# neutron port-update 5588a691-9695-4a02-b72d-5338b869f866 --fixed-ips type=dict {ip_address=10.1.0.23,subnet_id=b966187e-bde7-42a9-b15b-3473e68e06dd}
Updated port: 5588a691-9695-4a02-b72d-5338b869f866

root@console:~# ./Documents/python_test/Contrail_json.py -d virtual-machine-interface/5588a691-9695-4a02-b72d-5338b869f866
{
    "virtual-machine-interface": {
        "display_name": "5588a691-9695-4a02-b72d-5338b869f866",
        "fq_name": [
            "default-domain",
            "unregard1",
            "5588a691-9695-4a02-b72d-5338b869f866"
        ],
        "href": "http://172.27.113.202:8082/virtual-machine-interface/5588a691-9695-4a02-b72d-5338b869f866",
        "id_perms": {
            "created": "2015-12-17T04:05:18.153750",
            "creator": null,
            "description": null,
            "enable": true,
            "last_modified": "2015-12-21T05:27:03.367422",
            "permissions": {
                "group": "admin",
                "group_access": 7,
                "other_access": 7,
                "owner": "admin",
                "owner_access": 7
            },
            "user_visible": true,
            "uuid": {
                "uuid_lslong": 13199297585970018406,
                "uuid_mslong": 6163359234283358722
            }
        },
        "instance_ip_back_refs": [
            {
                "attr": null,
                "href": "http://172.27.113.202:8082/instance-ip/447a6191-d582-4c8e-9d58-248f65634523",
                "to": [
                    "447a6191-d582-4c8e-9d58-248f65634523"
                ],
                "uuid": "447a6191-d582-4c8e-9d58-248f65634523"
            },
            {
                "attr": null,
                "href": "http://172.27.113.202:8082/instance-ip/94012d38-bbe7-41f7-851b-2b233e5f1ab9",
                "to": [
                    "94012d38-bbe7-41f7-851b-2b233e5f1ab9"
                ],
                "uuid": "94012d38-bbe7-41f7-851b-2b233e5f1ab9"
            }
        ],
        "name": "5588a691-9695-4a02-b72d-5338b869f866",
        "parent_href": "http://172.27.113.202:8082/project/3d4496ba-5184-4ce4-b28e-6c1885268d62",
        "parent_type": "project",
        "parent_uuid": "3d4496ba-5184-4ce4-b28e-6c1885268d62",
        "routing_instance_refs": [
            {
                "attr": {
                    "direction": "both",
                    "dst_mac": null,
                    "mpls_label": null,
                    "protocol": null,
                    "service_chain_address": null,
                    "src_mac": null,
                    "vlan_tag": null
                },
                "href": "http://172.27.113.202:8082/routing-instance/1ca0b411-6955-46c9-b413-46c6d1f4bcd6",
                "to": [
                    "default-domain",
                    "unregard1",
                    "ipchange1",
                    "ipchange1"
                ],
                "uuid": "1ca0b411-6955-46c9-b413-46c6d1f4bcd6"
            }
        ],
        "security_group_refs": [
            {...

[Hari Prasad Killi (haripk)]

This scenario is not currently supported.

[Daisuke Nakajima (dnakajima)]

How will contrail support 'neutron port-update'?
In case of ip-address update, the attribute of instance-ip does not accept "PUT" operation for modifying IP address in R2.2 branch.
Will neutron plugin to "PUT" operation to 'instance-ip' or do "DELETE" and "POST" operation?
In former case, will 'instance-ip' accept "PUT" operation?

[Sachin Bansal (sbansal)]

We are going to disallow port-update if it is trying to change fixed ip on the port.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18790
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18790
Committed: http://github.org/Juniper/contrail-controller/commit/1c481ccae27a1e3228b5c59d84e6f3f8abaac098
Submitter: Zuul
Branch: master

commit 1c481ccae27a1e3228b5c59d84e6f3f8abaac098
Author: Sachin Bansal <email address hidden>
Date: Fri Mar 25 17:11:53 2016 -0700

Do not allow updating ip address on a port

Change-Id: I6fa23f8d1338dae105e5cf0d6ac7eec227f12b27
Closes-Bug: 1526260

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18836
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18836
Committed: http://github.org/Juniper/contrail-controller/commit/e37fea3bb8bc17e3fae2a1590928a02b481a60ba
Submitter: Zuul
Branch: R3.0

commit e37fea3bb8bc17e3fae2a1590928a02b481a60ba
Author: Sachin Bansal <email address hidden>
Date: Fri Mar 25 17:11:53 2016 -0700

Do not allow updating ip address on a port

Change-Id: I6fa23f8d1338dae105e5cf0d6ac7eec227f12b27
Closes-Bug: 1526260
(cherry picked from commit 1c481ccae27a1e3228b5c59d84e6f3f8abaac098)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18900
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18900
Committed: http://github.org/Juniper/contrail-controller/commit/f7a5b5720aed84287a79da746d06e7c7de645533
Submitter: Zuul
Branch: R2.20

commit f7a5b5720aed84287a79da746d06e7c7de645533
Author: Sachin Bansal <email address hidden>
Date: Fri Mar 25 17:11:53 2016 -0700

Do not allow updating ip address on a port

Change-Id: I6fa23f8d1338dae105e5cf0d6ac7eec227f12b27
Closes-Bug: 1526260